vercel/styled-jsx

CSS `content` property no longer renders encoded characters

Open

#589 opened on Oct 15, 2019

View on GitHub
 (17 comments) (1 reaction) (0 assignees)JavaScript (310 forks)batch import
bughelp wanted

Repository metrics

Stars
 (7,547 stars)
PR merge metrics
 (Avg merge 25d 23h) (1 merged PR in 30d)

Description

Do you want to request a feature or report a bug?

bug

What is the current behavior?

Old behavior now must be done through string-literal instead of standard string.

If the current behavior is a bug, please provide the steps to reproduce and possibly a minimal demo or testcase in the form of a Next.js app, CodeSandbox URL or similar

The following no longer works in NextJS 9.1.1 to render a encoded character:

<style jsx>{`
.whatever-class:after { content: "\\0025B6"; };
</style>

We now have to do:

.whatever-class:after { content: ${`"\\0025B6"`}; }

What is the expected behavior?

Standard way of rendering content should still work.

Environment (include versions)

  • OS: macOS Catalina
  • Browser: Chrome 77
  • styled-jsx (version): NextJS 9.1 bundled (styled-jsx@3.2.2)

Did this work in previous versions?

Yes

Contributor guide

Research direction
Investigate the styled jsx compiler source code (likely the babel plugin or the transform function) to understand how CSS strings are parsed and how escaped characters (like \\0025B6) are handled. Check the issue's comments for any discussion on the root cause or suggested fixes. Look for changes between version 3.2.2 and later that might have introduced the regression. The fix likely involves preserving the original escape sequence in the CSS output without converting it to a string literal.
Tech stack
javascriptreactcssnextjs
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Understanding of styled jsx internalsCSS content property escapingJavaScript template literals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40