vercel/release

GitHub Enterprise compatibility?

Open

#32 opened on Jan 5, 2017

View on GitHub
 (2 comments) (10 reactions) (0 assignees)JavaScript (145 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (3,534 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I've got GHE compatibility working in a fork I created, and was wondering if that is something you'd be open to accepting a PR for? Or is that something that you'd expect developers to fork-and-maintain their own version?

The configuration variables I had to override were:

  • host for GHE domain
  • pathPrefix for the api root path (typically api/v3)

And probably these too, but haven't confirmed yet:

  • username to replace zeit reference
  • clientId for custom oauth integration
  • authUrl for customizing the oauth server endpoint

Let me know what you think! I don't mind keeping a fork but would like to help contribute if that's something you eventually want.

Contributor guide

Research direction
Examine the configuration module in the repository (e.g., 'lib/config.js') to understand how variables like 'host' and 'pathPrefix' are currently set. Review the maintainer's response in the issue comments for acceptance of the feature. The user's fork can serve as a reference implementation for the required changes.
Tech stack
javascriptnodejs
Domain
clitooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.jsGitHub API basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70