vercel/release

Don't escape HTML within a certain character

Open

#118 opened on Feb 27, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (145 forks)batch import
bughelp wanted

Repository metrics

Stars
 (3,534 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This introduced this:

We need to ensure that we only escape HTML outside of `!

Contributor guide

Research direction
First, review the linked PR (#91) that introduced the escaping behavior. Then, search the codebase for escape functions, likely in a module handling markdown or HTML conversion. The issue indicates that HTML outside of a certain character (likely a backtick or code block) should be escaped, while inside it should not. Look at the existing logic to identify where the escaping occurs and how to conditionally apply it.
Tech stack
javascriptnodejs
Domain
releasecli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
basic JavaScriptfamiliarity with HTML escaping
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60