valyala/fasthttp

NewFastHTTPHandler does not set response status code

Open

#1,754 opened on Apr 9, 2024

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Go (1,755 forks)batch import
help wanted

Repository metrics

Stars
 (21,741 stars)
PR merge metrics
 (Avg merge 1d 11h) (34 merged PRs in 30d)

Description

I recreated the issue because the reopen button is not on the original issue.

The NewFastHTTPHandler() handler does not set the Status code for the response:

https://github.com/valyala/fasthttp/blob/master/fasthttpadaptor/adaptor.go#L59

I have pointed the line of code that needs to be updated to set the status from the ctx response.

The code in line 65 https://github.com/valyala/fasthttp/blob/d3a9c74c92588e83c465057c243e05b46d9118f7/fasthttpadaptor/adaptor.go#L65 Returns a nil value that eventually is changed to 200.

The fix needed is on line 59, the response

w := netHTTPResponseWriter{
	w:   ctx.Response.BodyWriter(),
	ctx: ctx,
}

needs to changed to:

w := netHTTPResponseWriter{
	w:   ctx.Response.BodyWriter(),
	statusCode: ctx.Response.StatusCode(), <---- this is needed
	ctx: ctx,
}

Line 65 needs to be removed since code is set by the caller, ctx already should contain the nil value or a status set by the caller.

Contributor guide

Research direction
Examine the file fasthttpadaptor/adaptor.go, specifically around line 59 and line 65. The fix involves adding a statusCode field to the netHTTPResponseWriter struct and initializing it with ctx.Response.StatusCode(), then removing the line that sets the status to nil (line 65). The issue description provides the exact code changes needed.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go programmingFamiliarity with fasthttp
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80