usebruno/bruno

Consider using stronger ACL on Environment files

Open

#2,016 opened on Apr 4, 2024

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (2,403 forks)batch import
good first issuehelp wantedmodule-environmentsmodule-filesystemmodule-security

Repository metrics

Stars
 (43,787 stars)
PR merge metrics
 (Avg merge 6d 19h) (74 merged PRs in 30d)

Description

Issue

When an Environment file is created, it is typically stored in the environments directory. On 'nix/BSD environments, those files are stored with world-readable perms (644 to be exact). While there is already some protection for sensitive data by using the "Secrets" checkbox, I could see people who accidentally/mistakenly still store sensitive creds and keys which could expose them.

I'd recommend you set an ACL for the Environment files to 600 by default. I can confirm that Bruno will continue to read and write to them just fine with those permissions set.

Contributor guide

Research direction
The issue proposes modifying the default file permissions for environment files from 644 to 600. Look for the code that creates environment files, likely in the app's file handling modules. The change is straightforward: set the file mode to 0o600 when writing. Test that reading and writing still works after the change.
Tech stack
javascriptelectron
Domain
securitydesktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.js file systemchmod usage
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75