umputun/remark42

Problematic logout doesn't show errors in the UI

Open

#1,455 opened on Jul 31, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Go (432 forks)user submission
bugfrontendhelp wanted

Repository metrics

Stars
 (5,500 stars)
PR merge metrics
 (Avg merge 7d) (7 merged PRs in 30d)

Description

I run remark42 like that: ./remark42.darwin-arm64 server --secret=12345 --url=http://127.0.0.1:8080.

If I was logged in before running that version (with no auth providers) I see a normal comment screen:

If I push the "log out" button, http://127.0.0.1:8080/auth/logout?site=remark request is made with status code 400 which has the following answer:

{
    "error": "providers not defined"
}

The interface shows nothing. In the console, I see the following:

Erroring code:

Contributor guide

Research direction
The issue is that the frontend does not display the error response from the logout API. The error from the backend is a 400 with 'providers not defined'. The frontend code that handles the logout response likely needs to catch and display this error. Look at the frontend's logout function (probably in a component that handles authentication) and ensure it shows the error message.
Tech stack
javascriptreactgo
Domain
full stack
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Basic knowledge of GoBasic knowledge of React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65