trixi-framework/Trixi.jl

Calculate timestep only once for equations with constant propagation speed

Open

#216 opened on Oct 11, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Julia (153 forks)batch import
enhancementgood first issueperformancetaal

Repository metrics

Stars
 (686 stars)
PR merge metrics
 (Avg merge 9d 1h) (37 merged PRs in 30d)

Description

For example, scalar advection and hyperbolic diffusion have constant propagation speeds, thus the time step needs to be calculated only once after each change of the mesh. This can be a performance improvement, especially when doing parallel simulations, where it saves one blocking collective communication per time step.

For this to work, first #215 needs to be resolved.

Contributor guide

Research direction
First, issue #215 must be resolved. Then, identify the equations in Trixi.jl that have constant propagation speeds, such as scalar advection and hyperbolic diffusion. The timestep calculation logic is likely in the time integration routines. The goal is to compute the timestep only once per mesh change instead of every time step, which will save blocking collective communication in parallel simulations.
Tech stack
None
Domain
performance
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
Resolve Trixi.jl issue #215
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15