schickling/chromeless

Pass chromePath and chromeFlags in Chromeless options to chrome-launcher

Open

#184 opened on Aug 6, 2017

View on GitHub
 (0 comments) (4 reactions) (0 assignees)TypeScript (606 forks)batch import
APIfeaturehelp wanted

Repository metrics

Stars
 (13,240 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Add chromePath and chromeFlags to ChromelessOptions which get passed to the chrome-launcher's constructor so that users can specify a path to their Chrome installation and provide custom flags.

Brought up in https://github.com/graphcool/chromeless/issues/158#issuecomment-320455862

Contributor guide

Research direction
Examine the chrome launcher package to understand its constructor options and how to pass them through ChromelessOptions.
Tech stack
typescriptnodejs
Domain
backendtooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75