rust-lang/rust-analyzer

StructuralSearchReplace: next steps

Open

#3,186 opened on Feb 17, 2020

View on GitHub
 (35 comments) (2 reactions) (0 assignees)Rust (1,726 forks)batch import
A-ideE-hardS-actionablefungood first issue

Repository metrics

Stars
 (14,924 stars)
PR merge metrics
 (Avg merge 4d 22h) (101 merged PRs in 30d)

Description

https://github.com/rust-analyzer/rust-analyzer/pull/3099 implemented initial version of SSR.

This issue collects things we need to do to make this really production-read

@mikhail-m1 any other things I've missed?

Contributor guide

Research direction
Study the existing SSR implementation in rust analyzer, particularly the matching code at https://github.com/rust analyzer/rust analyzer/pull/3099/files#diff 474f1919c71ce1731ad967e353b69b21R173, and implement the improvements listed: handling trivia, semantic equivalence, and adding support for other matchers like `$type` or `$path`. Begin with the trivia handling as it seems simpler.
Tech stack
rust
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35