rust-lang/futures-rs

Deadlock detection for futures::lock::Mutex

Open

#2,133 opened on Apr 22, 2020

View on GitHub
 (1 comment) (6 reactions) (0 assignees)Rust (552 forks)batch import
A-lockC-feature-requesthelp wanted

Repository metrics

Stars
 (4,701 stars)
PR merge metrics
 (Avg merge 22d 16h) (3 merged PRs in 30d)

Description

It would be really nice if Mutex had deadlock detection (including via a feature flag). Especially in an async context where it's hard to peer into the state of tasks, these can be exceptionally hard to debug.

parking_lot does this for its synchronous locks, though it requires you to trigger detection manually on another thread.

cc @ctiller

Contributor guide

Research direction
Investigate parking lot's deadlock detection implementation (https://amanieu.github.io/parking lot/parking lot/deadlock/index.html) and adapt it to the async context of futures::lock::Mutex. Consider using a feature flag to enable detection. Review existing discussions in issue #2133 and any related PRs. The goal is to provide a mechanism to detect and report deadlocks, aiding debugging in async environments.
Tech stack
rust
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust asyncfutures rsdeadlock detection
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20