reactjs/react-modal

How do I close Modal on right click in overlay?

Open

#837 opened on Nov 15, 2020

View on GitHub
 (6 comments) (0 reactions) (1 assignee)JavaScript (828 forks)batch import
easyfeaturehelp wanted

Repository metrics

Stars
 (7,294 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Summary:

I wish to close the modal on secondary click (right mouse click). This works in your codepen demo for v.1.6.2: https://codepen.io/claydiffrient/pen/ZBmyKz?editors=1111 But not in my own demo with v3.3.2, see here: https://codepen.io/CharlotteA/pen/PozLwNw?editors=1111

Am I missing a new prop to handle this?

Expected behavior:

Close on right-click: https://codepen.io/claydiffrient/pen/ZBmyKz?editors=1111

Link to example of issue:

Not closing on right-click: https://codepen.io/CharlotteA/pen/PozLwNw?editors=1111

Any help very much appreciated!  🤓

Contributor guide

Research direction
Investigate the current EventManager.js in react modal to understand how click events are handled. Review the change from v1.6.2 to v3.3.2 that removed the right click close behavior. Check the GitHub issues and PRs for any related discussion on right click handling. Consider adding a prop like 'closeOnRightClick' or re enabling the default behavior.
Tech stack
reactjavascriptcss
Domain
frontendaccessibility
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
React basicsreact modal library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60