reactjs/react-modal

Add support for React & Node 18 (as easy as adding startTransition() on each setState)

Open

#1,019 opened on May 8, 2023

View on GitHub
 (19 comments) (0 reactions) (0 assignees)JavaScript (828 forks)batch import
easygood first issue

Repository metrics

Stars
 (7,294 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Summary:

Current react modal doesn't work with latest version of React + Node v18

Steps to reproduce:

  1. Use react-modal with latest React's and Node v18

Expected behavior:

Should work normally

Example of issue:

Breaks with the following error message:

Solution:

Simply add startTransition() wrapping each of the calls for setting the state. startTransition(() => setState("something))

Contributor guide

Research direction
The issue requires adding startTransition() to each setState call in the react modal component. First, identify all state updates in the source code, likely in the main modal component file. Then, wrap each setState with startTransition to make it compatible with React 18. Ensure no breaking changes and test with the latest React version.
Tech stack
javascriptreact
Domain
frontendaccessibility
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React fundamentalsstartTransition APIreact modal codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75