pytorch/text

[Help Want] Switch from common.torchtext_test_case.TorchtextTestCase to torch.testing._internal.common_utils.TestCase

Open

#824 opened on Jun 11, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (822 forks)batch import
help wanted

Repository metrics

Stars
 (3,396 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

TestCase.assertEqual supports torch.tensor. Here are a few files required to change:

  • test/*.py
  • test/data/test_*.py

Link example PRs: https://github.com/pytorch/text/pull/822 and https://github.com/pytorch/text/pull/823

Contributor guide

Research direction
Review the linked example PRs to understand the pattern, then modify all test files under test/ and test/data/ to replace TorchtextTestCase with TestCase.
Tech stack
pythonpytorch
Domain
testing
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPythonPyTorch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85