pinojs/pino

bindings() and setBindings() are not present in the browser version of pino

Open

#1,177 opened on Oct 20, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (839 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (13,157 stars)
PR merge metrics
 (Avg merge 1h 28m) (1 merged PR in 30d)

Description

Hello!

I was attempting to use pino in the browser today and discovered that .bindings() is undefined. Additionally, .setBindings() is also undefined, but it's also undocumented in general (is it officially part of the API?).

I looked into adding this to browser.js but I'd definitely need some guidance before proceeding. For example, I'm not sure if bindings changes cascade through child loggers or if they are fixed at the time of child creation, for example.

Contributor guide

Research direction
Examine the pino source code to understand how bindings() and setBindings() work in the Node.js version. Then adapt the browser.js to include these methods, ensuring they behave consistently, especially with child loggers.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70