nodejs/node

FormData, Response, Request, and Headers have incorrect property descriptors

Open

#45,099 opened on Oct 20, 2022

View on GitHub
 (7 comments) (1 reaction) (0 assignees)JavaScript (35,535 forks)batch import
confirmed-bughelp wanted

Repository metrics

Stars
 (117,218 stars)
PR merge metrics
 (Avg merge 13d 4h) (233 merged PRs in 30d)

Description

Version

v18.11.0

Platform

Microsoft Windows NT 10.0.19043.0 x64

Subsystem

No response

What steps will reproduce the bug?

The property descriptors should match such that this test succeeds:


for (const global of [
  'Headers',
  'Request',
  'Response',
  'FormData'
]) {
  const desc = Object.getOwnPropertyDescriptor(globalThis, global)
  
  assert.notStrictEqual(desc, undefined)
  assert.deepStrictEqual(desc.value, globalThis[global])
  assert.ok(desc.writable)
  assert.ok(!desc.enumerable)
  assert.ok(desc.configurable)
}

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

the tests from above pass

What do you see instead?

the descriptors are inconsistent with other environments

Additional information

No response

Contributor guide

Research direction
Investigate the property descriptors for Headers, Request, Response, and FormData in Node.js. The correct descriptors should have writable: true, enumerable: false, configurable: true. Check the source code in lib/internal/webapi/ or similar files where these globals are defined. Compare with browser implementations to ensure consistency. The fix would involve setting the property descriptor appropriately, possibly using Object.defineProperty.
Tech stack
javascriptnodejs
Domain
apibackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript property descriptorsNode.js internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50