nextcloud/server

Migrations generated via occ fail psalm validation

Open

#34,555 opened on Oct 12, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)PHP (4,865 forks)batch import
1. to developfeature: install and updategood first issueneeds reviewtechnical debt

Repository metrics

Stars
 (34,953 stars)
PR merge metrics
 (Avg merge 17d 3h) (606 merged PRs in 30d)

Description

Actually such migrations fail psalm:

Error: ….php:42:56: MoreSpecificImplementedParamType: Argument 2 of …::changeSchema has the more specific type 'Closure():OCP\DB\ISchemaWrapper', expecting 'Closure' as defined by OCP\Migration\SimpleMigrationStep::changeSchema (see https://psalm.dev/140)

So I guess we have to revert it or update the base class as well?

Originally posted by @nickvergessen in https://github.com/nextcloud/server/issues/34488#issuecomment-1275904697

Contributor guide

Research direction
Inspect the migration generation code in occ command and update the base class SimpleMigrationStep::changeSchema to accept the more specific Closure type or revert the change that caused the issue.
Tech stack
php
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPHP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70