nextcloud/android

Checking for latest version at every "All files" screen

Open

#1,996 opened on Jan 18, 2018

View on GitHub
 (4 comments) (1 reaction) (0 assignees)Java (1,719 forks)batch import
bugdev versiongood first issuepapercut

Repository metrics

Stars
 (3,752 stars)
PR merge metrics
 (Avg merge 8d 21h) (66 merged PRs in 30d)

Description

Actual behavior

When I go to the root "all files" screen, the app checks if the last version is installed. I have a small lag (sometimes a fast blackscreen), and I have the message about version "No new version" or "New version available". If I use NC app and my smartphone became locked, I unlock and the screen of NC have the same behavior (lag + message at bottom)

Expected behaviour

No lag, why not just notification in the notification bar of android ? A check when I am in "expert mode" only ? A check when I am in settings only ? A check per day ?

Steps to reproduce

  1. Go to the "home" page "All files"

Environment data

Android version: 7.1.2

Device model: Nexus 4

Stock or customized system: Lineageos 14.1

Nextcloud app version: 20180118

Nextcloud server version: 12.0.4

Contributor guide

Research direction
Examine the 'All files' screen code to identify where the version update check is performed. Look for an update checker class or a network call in the activity lifecycle. Consider moving the check to a background task that runs at most once per day or moving it to the settings screen. The repository is Java based, so focus on Java source files in the app module.
Tech stack
androidjava
Domain
mobileperformance
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Android development environmentJava knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65