monicahq/monica

Support Docker secrets

Open

#5,809 opened on Dec 28, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)PHP (2,464 forks)batch import
dockerhelp wanted

Repository metrics

Stars
 (24,641 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe.

Describe the solution you'd like Support docker secrets. Either by adding new environment variables such as DB_PASS_FILE which actually does a cat /run/secrets/DB_PASS_FILE inside the container - or we could have some logic that checks whether /run/secrets/DB_PASS exists and overwrites whatever is in environment variable DB_PASS.

Describe alternatives you've considered (optional) Have my secrets in the .env file

Contributor guide

Research direction
Investigate the current Docker Compose setup and entrypoint scripts (likely in 'docker/' directory or entrypoint.sh). Determine how environment variables are loaded (probably via a PHP script that parses .env). Implement support for Docker secrets by either adding FILE suffixed variables or checking /run/secrets/ directory. Ensure backwards compatibility and document the change. Consult the Docker documentation for secrets and the MonicaHQ Docker deployment guide.
Tech stack
dockerphp
Domain
backenddevopssecurity
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Docker basicsDocker secrets conceptPHP environment variables
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70