keystonejs/keystone-classic

Code format lost if using dependsOn

Open

#4,608 opened on Apr 4, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,288 forks)batch import
bughelp wanted

Repository metrics

Stars
 (14,656 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected behavior

When using dependsOn in a Type.Code field, it should keep its code formating.

Actual/Current behavior

When using dependOn in Type.Code field, the format defaults to a plain text field.

Steps to reproduce the actual/current behavior

code: {type: Types.Code, dependsOn: {type: "code"}"}

Environment

Software Version
Keystone 4.0.0-beta.5
Node v8.10.0

Contributor guide

Research direction
Examine the Code field type implementation, likely in `fields/types/Code.js`. Investigate how `dependsOn` affects the field's rendering: the issue reports that the code format (editor) is lost and defaults to a plain text field when `dependsOn` is used. Look at the field definition and any conditional logic that might disable the code editor. Since no comments or PRs exist and the issue is from 2018, first verify if the bug persists in the current version of keystone classic. If reproducing, check the related field type registration and how `dependsOn` is processed during field initialization.
Tech stack
javascriptnodejs
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Basic understanding of Keystone field typesFamiliarity with dependsOn
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35