keystonejs/keystone-classic

Prompt to save changes to a post before navigating away

Open

#4,491 opened on Nov 1, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,288 forks)batch import
feature requesthelp wanted

Repository metrics

Stars
 (14,656 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected behavior

We should track when changes are made to the form since the last save, and if the user is navigating away from the edit page while there are unsaved changes, prompt them to save or to confirm their navigation action.

Actual/Current behavior

Current behavior is that there is no check for unsaved changes. If the user accidentally navigates away from the edit page, then these changes are lost.

Steps to reproduce the actual/current behavior

  1. Select a post from the admin page to edit
  2. On the edit screen, make some changes to the post
  3. Navigate away from the edit screen without clicking the save button

At this point, if you view the selected post, the unsaved changes will be lost.

Environment

Software Version
Keystone master branch of the repo (npm linked)
Node 6.11.2

Contributor guide

Research direction
Track the dirty state of the form and add a beforeunload event listener or intercept client side navigation to prompt the user to save changes before leaving.
Tech stack
javascriptnodejs
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75