jieter/django-tables2

Rendering a callable attribute value in a LinkColumn

Open

#858 opened on Aug 3, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (417 forks)batch import
Help wanted

Repository metrics

Stars
 (1,693 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Working example:

class OverviewTable(django_tables2.Table):
    label = django_tables2.LinkColumn(
        'details',
        args=[django_tables2.utils.A('pk')],
        attrs = {'td': {'id': lambda value: value}},
    )

Expected to work but not working example:

class OverviewTable(django_tables2.Table):
    label = django_tables2.LinkColumn(
        'details',
        args=[django_tables2.utils.A('pk')],
        attrs = {'a': {'id': lambda value: value}},
    )

Raises TypeError: <lambda>() missing 1 required positional argument: 'value' at this point: https://github.com/jieter/django-tables2/blob/7a30b0a1d8ab78f010df91af8fd5d31e411b8122/django_tables2/utils.py#L468

Surely, the documentation doesn't directly suggest that it works, but it seems reasonable to assume. Also the documentation doesn't give a clue that a callable is even supported here. Seems like an unfinished effort to make it work?

Contributor guide

Research direction
Examine the code in django tables2/utils.py around line 468 to understand how callable attributes are processed. Check the git history for any previous changes to that section. Review the documentation for attrs in LinkColumn to see if callables are supported. The fix should ensure callables receive the cell value consistently for all HTML tag attributes.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Django basicsdjango tables2Python functions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60