jazzband/django-silk

Incompatible with django-channels

Open

#216 opened on Oct 5, 2017

View on GitHub
 (6 comments) (9 reactions) (0 assignees)Python (319 forks)batch import
bughelp wanted

Repository metrics

Stars
 (3,958 stars)
PR merge metrics
 (Avg merge 14d) (2 merged PRs in 30d)

Description

This was mentioned in #65 but it is very old. Even putting silk middleware as the very first item in MIDDLEWARE doesn't prevent the error.

How can we work around this to at least use Silk to profile everything but channels?

Contributor guide

Research direction
Investigate the compatibility issue between django silk and django channels. Start by examining the middleware code in silk/middleware.py and the ASGI handler in channels. Look for any conflict in request processing order. Check the linked issue #65 for prior discussion and potential workarounds. Test with a minimal Django Channels app and try adjusting middleware placement or using a custom middleware that bypasses channels URLs.
Tech stack
python
Domain
backendperformance
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Django basicsDjango middlewareDjango Channels
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20