jaegertracing/jaeger

Enable more revive linter rules

Open

#5,506 opened on Jun 2, 2024

View on GitHub
 (26 comments) (0 reactions) (0 assignees)Go (2,326 forks)batch import
good first issuehelp wanted

Repository metrics

Stars
 (18,974 stars)
PR merge metrics
 (Avg merge 5d 7h) (75 merged PRs in 30d)

Description

In #5505 we introduced a revive linter, but had to disable many of its rules because they were breaking on some places in the code. https://github.com/jaegertracing/jaeger/blob/b38d2f9bc18806b6e716f6f666a786f0aca7d912/.golangci.yml#L154

We can re-enable those rules incrementally by fixing the corresponding breaks one rule at a time (make lint should succeed) and removing the disabling entry from the config.

Strong advice: DO NOT OPEN A PR without discussing the impact of the specific linter on this issue first. We don't want very possible linter - some of them are stupid, others require a lot of code changes with minimal benefits.

Contributor guide

Research direction
Discuss the impact of a specific revive linter rule on the issue before making changes. Pick one disabled rule, understand the code breaks, and fix them incrementally, ensuring `make lint` passes.
Tech stack
go
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50