ionic-team/ionicons

Can you expose a part="svg" for the SVG content

Open

#960 opened on Apr 16, 2021

View on GitHub
 (5 comments) (9 reactions) (0 assignees)TypeScript (2,083 forks)batch import
help wanted

Repository metrics

Stars
 (17,256 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When using it with custom icons : <ion-icon src="assets/icons/wifi.svg"></ion-icon> Because of the Shadow DOM we can't style at all the content of the SVG. Any custom SVG used is always a square because of the this css lines : https://github.com/ionic-team/ionicons/blob/8c2a507fcff2cb5f2edff60357ffd7feb70bb987/src/components/icon/icon.css#L27-L34 By adding a part="svg" it would be possible to have more flexibility to style the SVG from the outside. In my case setting height to auto, but it could be to change the color of a specific path or anything else.

Contributor guide

Research direction
Investigate adding CSS part attribute to the SVG element inside the Shadow DOM in the ion icon component. Check the existing icon CSS and TypeScript files to understand the structure, then add part="svg" to the SVG element and update types accordingly.
Tech stack
typescriptcsshtml
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Shadow DOMCSS parts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60