graphql-python/graphene-django

GraphQLView should detect batch requests

Open

#967 opened on May 21, 2020

View on GitHub
 (7 comments) (1 reaction) (0 assignees)Python (754 forks)batch import
help wanted✨enhancement

Repository metrics

Stars
 (4,173 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Is there a valid reason why the GraphQLView input is validated to either only ever accept batched requests or never accept batched requests. Is it not reasonable to accept both?

https://github.com/graphql-python/graphene-django/blob/ee120c48e16dda818cb253fdc36b7053402956b0/graphene_django/views.py#L217

Contributor guide

Research direction
The issue requests modifying the GraphQLView in graphene django/views.py to detect and accept both batched and single GraphQL requests. The relevant code is at line 217 (linked in the issue). Currently, the view validates the input to expect either a list or a single object, but not both. A first time contributor should examine the parse body or dispatch method to implement logic that checks the request body type (list or dict) and processes accordingly. The goal is to allow a client to send either format without breaking existing functionality.
Tech stack
pythondjangographql
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Basic Django knowledgeGraphQL basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80