graphql-python/graphene-django

Converters cannot convert datetime.timedelta to float.

Open

#348 opened on Dec 18, 2017

View on GitHub
 (9 comments) (3 reactions) (0 assignees)Python (754 forks)batch import
help wanted✨enhancement

Repository metrics

Stars
 (4,173 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

hello devs. During a conversation about an issue of graphql-core @jkimbo found a possible error

https://github.com/graphql-python/graphene-django/blob/5051d3bb617ce6977eebc023c958bd10de91fe91/graphene_django/converter.py#L111-L113

raising something like { "message": "float() argument must be a string or a number, not 'datetime.timedelta'" }

you can check https://github.com/graphql-python/graphql-core/issues/150 for more info.

Contributor guide

Research direction
Inspect the converter.py file, specifically lines 111-113, and implement a converter that handles datetime.timedelta by converting it to a float (e.g., total seconds).
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonDjango
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80