grafana/k6

Move Sobek option parsing to the mapping layer

Open

#5,305 opened on Oct 14, 2025

View on GitHub
 (28 comments) (0 reactions) (1 assignee)Go (1,537 forks)batch import
area: browsergood first issuerefactor

Repository metrics

Stars
 (30,564 stars)
PR merge metrics
 (Avg merge 11d 22h) (44 merged PRs in 30d)

Description

What

  • Move Sobek option parsing to the mapping layer.

Why

  • Separation of concerns.
  • Option parsing is only required by the mapping layer.
  • To simplify and make the code and tests easy to reason about.

Current options to move

  • Frame options
  • ElementHandleBaseOptions
  • PageReloadOptions
  • PageScreenshotOptions
  • Locator options
  • Size.Parse
  • #5687
  • #5302
  • #5560

Example

  • In this code, the parsing happens in the mapping layer.

Related

  • This issue is a continuation of the epic issue #4219.

Contributor guide

Research direction
Examine the existing option parsing in the mapping layer (e.g., locator mapping.go) and identify where Sobek option parsing occurs. Then refactor to move those parsing functions to the mapping layer, ensuring tests are updated accordingly.
Tech stack
go
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50