golang/go

x/tools/go/analysis/passes/modernize: add testingsetenv analyzer

Open

#77,735 opened on Feb 22, 2026

View on GitHub
 (13 comments) (4 reactions) (1 assignee)Go (19,008 forks)batch import
FeatureRequestProposalToolshelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Proposal Details

Add a new analyzer that replaces manual environment variable save/restore with t.Setenv (Go 1.17+).

// Before
defer os.Setenv("GOOS", os.Getenv("GOOS"))
os.Setenv("GOOS", f[0])

// After
t.Setenv("GOOS", f[0])

Conditions

  • Pattern: defer os.Setenv(key, os.Getenv(key)) followed by os.Setenv(key, value)
  • defer must precede os.Setenv (defer args are evaluated immediately)
  • Within test function, before any t.Parallel() call
  • Go 1.17+

Similar to testingcontext analyzer.

Contributor guide

Research direction
Study the existing modernize analyzers (e.g., testingcontext) in the x/tools repository. Understand the pattern matching for defer os.Setenv followed by os.Setenv, and implement a new analyzer using the same analysis framework.
Tech stack
go
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gostatic analysis
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65