fastify/fastify-rate-limit

Support node-redis, possibly along with ioredis?

Open

#368 opened on May 15, 2024

View on GitHub
 (15 comments) (0 reactions) (0 assignees)JavaScript (76 forks)auto 404
good first issue

Repository metrics

Stars
 (594 stars)
PR merge metrics
 (Avg merge 8d 18h) (4 merged PRs in 30d)

Description

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

Add support for redis package.

Motivation

According to the issue in ioredis(https://github.com/redis/ioredis/issues/1870#issuecomment-2029351413), the future mainstream package is going to be redis, not ioredis.

So I think it's a good idea to support redis package.

Example

No response

Contributor guide

Research direction
Review the existing ioredis adapter in the codebase, likely in a file like lib/redis ioredis.js. Create a similar adapter for the redis package, ensuring the API matches the required interface. Test with the plugin's existing test suite. Reference the discussion in issue #368 and any comments for edge cases.
Tech stack
nodejsredis
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Node.js knowledgeRedis understandingfastify rate limit plugin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40