facebook/fresco

PlaceholderImageScaleType sometimes doesn't work

Open

#2,481 opened on Mar 25, 2020

View on GitHub
 (12 comments) (0 reactions) (0 assignees)Java (3,750 forks)batch import
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (17,072 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

PlaceholderImageScaleType doesn't work

  • When I use the attribute of the roundedcorner， placeholderImageScaleType not normal work, like I set, on the system version for Android P's phone

  • Fresco version：com.facebook.fresco:fresco:2.1.0

 <com.facebook.drawee.view.SimpleDraweeView
        android:id="@+id/draweePoiIcon"
        android:layout_width="70dp"
        android:layout_height="50dp"
        android:layout_marginStart="12dp"
        android:layout_marginTop="12dp"
        android:scaleType="fitCenter"
        app:actualImageScaleType="fitCenter"
        app:placeholderImage="@drawable/poi_detail_image_place_holder"
        app:placeholderImageScaleType="fitCenter"
        app:roundedCornerRadius="5dp" />
  • The actual rendering shown：

  • The source file used： original_image

  • I hope to get your help. Thank you very much

@oprisnik

Contributor guide

Research direction
Investigate the interaction between placeholderImageScaleType and rounded corners in SimpleDraweeView. Look at the source code for PlaceholderImageScaleType attribute handling, possibly in DraweeHierarchy or similar classes. Check the comments in the issue for any maintainer guidance. Also search for existing tests related to scale types and rounding.
Tech stack
javaandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Android developmentFresco basicsXML layout attributes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60