expressjs/multer

Filesize in mutliple upload returns fieldname instead of filename

Open

#607 opened on Jun 27, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (1,043 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (11,136 stars)
PR merge metrics
 (Avg merge 9d 11h) (7 merged PRs in 30d)

Description

that is worth when you want to upload multiple files and one file is above filesize limitation. you´re not able to inform user about that rejected file... https://github.com/expressjs/multer/blob/master/lib/make-middleware.js#L141 pls, change fieldname to filename, or even better with the file object

Contributor guide

Research direction
Inspect the file lib/make middleware.js around line 141. Change the error message from using fieldname to using the filename (from the file object) when a file exceeds the size limit. Also consider including the entire file object for more detailed error information.
Tech stack
javascriptnodejs
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75