enzymejs/enzyme

getDerivedStateFromProps called from setState

Open

#2,078 opened on Apr 2, 2019

View on GitHub
 (2 comments) (3 reactions) (0 assignees)JavaScript (2,016 forks)batch import
bughelp wanted

Repository metrics

Stars
 (19,979 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Current behavior

getDerivedStateFromProps is being called from within setState, instead of before render, which overwrites the state and is inconsistent with react behavior. Please see attached codesandbox. There is a FloatInput.spec.js file with a unit test to show the behavior.

Expected behavior

getDerivedStateFromProps should be called before render not from setState.

Your environment

https://codesandbox.io/s/vqrm0r0r30

API

  • [x ] shallow
  • mount
  • render

Version

library version
enzyme 3.9.0
react 16.8.3
react-dom 16.8.3
react-test-renderer
adapter (below)

Adapter

  • [x ] enzyme-adapter-react-16
  • enzyme-adapter-react-16.3
  • enzyme-adapter-react-16.2
  • enzyme-adapter-react-16.1
  • enzyme-adapter-react-15
  • enzyme-adapter-react-15.4
  • enzyme-adapter-react-14
  • enzyme-adapter-react-13
  • enzyme-adapter-react-helper
  • others ( )

Contributor guide

Research direction
Examine the enzyme shallow renderer implementation, specifically how getDerivedStateFromProps is invoked. Review the provided codesandbox (https://codesandbox.io/s/vqrm0r0r30) and the FloatInput.spec.js test file. The issue indicates that getDerivedStateFromProps is called from setState instead of before render. Look at the adapter for React 16 (enzyme adapter react 16) to identify where the lifecycle method is called incorrectly. Ensure the fix aligns with React's behavior where getDerivedStateFromProps should be called during the render phase, not from state updates.
Tech stack
reactjavascript
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactenzymeJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60