cssinjs/jss

Previous styles not being removed when returning 'null' values using dynamic rule sets.

Open

#1,421 opened on Nov 7, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (434 forks)batch import
bughelp wanted

Repository metrics

Stars
 (7,000 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

NOTE: Similar to https://github.com/cssinjs/jss/issues/1026, but with dynamic rule sets instead of dynamic values.

Just to clarify nomenclature... dynamic rule set Vs. dynamic value:

{
  // DYNAMIC RULE SET
  a: ({color}) => ({
    display: 'inline',
    color: color
  }) ,
  b: {
    display: 'inline',
    // DYNAMIC VALUE
    color: ({ color }) => color
  }
}

Expected behavior: Previous applied values to be removed when respective value is set to null in a dynamic rule set.

Describe the bug: Previous values are not removed causing a number of trouble.

Codesandbox link: https://codesandbox.io/s/fervent-dawn-uomkr

Versions:

  • JSS: 10.4.0
  • Browser: All
  • OS: macOS 10.15.7

Contributor guide

Research direction
Examine the JSS source code for handling dynamic rule sets, particularly the updatePath logic. Compare with dynamic values handling. The codesandbox provides a minimal reproduction. Investigate why null values do not trigger removal of previous styles. Look at related issue #1026 for context.
Tech stack
javascriptcss
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Familiarity with JSS APIUnderstanding of dynamic rule sets vs dynamic values
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50