cssinjs/jss

Dynamic styles and vendor prefixes not working as expected

Open

#1,409 opened on Oct 16, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (434 forks)batch import
bughelp wanted

Repository metrics

Stars
 (7,000 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected behavior: I have a dynamic style that read a prop and return its value, I think that the vendor prefixes plugin is not working well in this case.

Describe the bug: I tried to generate the a css class with lineClamp key inside it, I expected that this is transformed to 'webkit-line-clamp'. This works well if I use a static style, but it doesn't if it is a dynamic one.

If I change the order in which the plugins are created and move 'jss-plugin-vendor-prefixer' to the first element, it seems to work.

Codesandbox link: https://codesandbox.io/s/lucid-sutherland-7l2ry?file=/src/App.js

Versions (please complete the following information):

  • jss: 10.4
  • Browser [e.g. chrome, safari]: Chrome
  • OS [e.g. Windows, macOS]: macOS/Linux

Contributor guide

Research direction
Investigate why dynamic styles bypass the vendor prefixer when it is not the first plugin. Check the plugin order in JSS createStyleSheet or similar. Look at jss plugin vendor prefixer source to see if it filters non static rules. Reproduce the issue using the provided codesandbox and test with different plugin orders. Consider if the fix should ensure vendor prefixer always runs on all rules regardless of order.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Understanding of JSS plugin system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45