avo-hq/avo

link_to_record: true, remember ?via_record_id=xxx&via_resource_class=yyy

Open

#3,475 opened on Dec 2, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Ruby (308 forks)user submission
EnhancementHelp wantedStale exempt

Repository metrics

Stars
 (1,778 stars)
PR merge metrics
 (Avg merge 1d 1h) (82 merged PRs in 30d)

Description

Feature

see https://www.loom.com/share/eb42935e2725476f945e60b79ff84d40

When clicking on rows within an association and you have the link_to_record: true, we go the right record ✅ but forget the association ❌ which makes the user experience inconsistent This is especially the case with the global config.click_row_to_view_record = true which does the right thing on all non belongs-to columns, but forgets about the via_record_id parameter on belongs_to fields...

# resource 1 (table)
field :columns, as: :has_many

# resource 2 (columns)
def fields
        field :foobar, as: :belongs_to, link_to_record: true # correctly will open the `column` resource (i.s.o. foobar) yet forgets about the table (resource 1)
end

Current workarounds

switch all :belongs_to to :text and format_using in !view.form? but feels very dirty

Contributor guide

Research direction
Investigate the implementation of `link to record` for belongs to fields in Avo. Locate where the record URL is generated (likely in a view helper or component for association rows). Ensure that the `via record id` and `via resource class` parameters are included in the link when `link to record` is true. Test with a belongs to field in a has many context to verify consistency with non belongs to behavior.
Tech stack
rubyrails
Domain
full stack
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Ruby on RailsAvo frameworkRails associations
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60