apache/incubator-seata

Is it necessary that both the RM client and the TM client start a timer for reconnecting to seata server ？

Open

#5,338 opened on Feb 13, 2023

View on GitHub
 (2 comments) (0 reactions) (1 assignee)Java (8,878 forks)batch import
good first issue

Repository metrics

Stars
 (25,960 stars)
PR merge metrics
 (Avg merge 20d 17h) (27 merged PRs in 30d)

Description

  • I have searched the issues of this repository and believe that this is not a duplicate.

Ⅰ. Issue Description

Is it necessary that both rm client and tm client start a timer for reconnecting to seata server？

The log of 2 timeoutCheckers is as follows： 2023-02-13 10:12:51.547 INFO 4079 --- [eoutChecker_1_1] i.s.d.r.k8s.K8sRegistryServiceImpl 2023-02-13 10:12:51.917 INFO 4079 --- [eoutChecker_2_1] i.s.d.r.k8s.K8sRegistryServiceImpl 2023-02-13 10:13:01.547 INFO 4079 --- [eoutChecker_1_1] i.s.d.r.k8s.K8sRegistryServiceImpl 2023-02-13 10:13:01.916 INFO 4079 --- [eoutChecker_2_1] i.s.d.r.k8s.K8sRegistryServiceImpl

io.seata.core.rpc.netty.AbstractNettyRemotingClient#init
public void init() {
        timerExecutor.scheduleAtFixedRate(new Runnable() {
            @Override
            public void run() {
                clientChannelManager.reconnect(getTransactionServiceGroup());
            }
        }, SCHEDULE_DELAY_MILLS, SCHEDULE_INTERVAL_MILLS, TimeUnit.MILLISECONDS);

Contributor guide

Research direction
Investigate whether both RM client and TM client need separate reconnect timers. The issue points to `io.seata.core.rpc.netty.AbstractNettyRemotingClient#init` where a single timer is scheduled. Review the code to see if both clients share this class or have separate instances. Consider consolidating into one timer if appropriate, or document why two are needed. Check related comments in the issue for maintainer feedback.
Tech stack
java
Domain
backenddatabase
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Basic understanding of Seata's architectureFamiliarity with Java and Netty
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40