apache/dolphinscheduler

[Bug] When contains multiple sub-processes, the task instance in the sub-process instance obtains duplicate parameters of the pre-task instance.

Open

#16,879 opened on Dec 5, 2024

View on GitHub
 (13 comments) (0 reactions) (0 assignees)Java (4,324 forks)batch import
bughelp wanted

Repository metrics

Stars
 (11,659 stars)
PR merge metrics
 (Avg merge 1d 17h) (22 merged PRs in 30d)

Description

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

在工作流中，创建多个子流程，例如创建12个子流程，子流程在获取上游任务参数时，会出现覆盖/错误/以及12个节点拿到的参数完全一致，这不符合预期 通过数据库中查询来看，生成的12的子流程实例，参数没有问题，但是在varpool的设置阶段，获取parent_process_instance_id所对应的varpool，是相同的，这导致子流程实例中的任务实例，执行时的参数永远是相同的

What you expected to happen

通过数据库中查询来看，生成的12的子流程实例，参数没有问题，但是在varpool的设置阶段，获取parent_process_instance_id所对应的varpool，是相同的，这导致子流程实例中的任务实例，执行时的参数永远是相同的 通过debug setSubProcessParam这个方法，能够看出每个子流程任务实例获取到的varpool参数都有问题，并且会随机出现重复

How to reproduce

我已经验证了3.2.1的standalone镜像，3.2.2的standalone镜像，debug镜像代码，都存在此问题，也可以在这两个镜像web服务页面，复现。我提供了我的验证工作流json，⚠️注意：导入后需要更改主流程中子流程的引用为新的id workflow_1733366901095.json

Anything else

No response

Version

3.2.x

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Contributor guide

Research direction
Start by examining the setSubProcessParam method in the sub process task executor. The issue indicates that varpool retrieval uses parent process instance id leading to duplicate parameters. Investigate how multiple sub process instances are identified and ensure each sub process fetches its own varpool. Consider adding unit tests to verify parameter isolation across concurrent sub processes.
Tech stack
java
Domain
backenddata
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaDolphinScheduler basicsDebugging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35