ansible/molecule

molecule login should auto call create if needed

Open

#2,469 opened on Dec 10, 2019

View on GitHub
 (0 comments) (4 reactions) (0 assignees)Python (636 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (3,686 stars)
PR merge metrics
 (Avg merge 18d 16h) (9 merged PRs in 30d)

Description

If instances are not created, executing molecule login should also run create instead of giving the error below:

$ molecule login                                                                                                                                                                        [11:54:43]
--> Validating schema /.../molecule/default/molecule.yml.
Validation completed successfully.
ERROR: Instances not created.  Please create instances first.
FAIL: 1

This should improve the user experience, making very easy to step-inside an instance.

Contributor guide

Research direction
Look at the current implementation of the `molecule login` command, likely in `molecule/command/login.py`. Understand how it checks for instance creation and throws the error. The `create` command is in `molecule/command/create.py`. You'll need to modify the login command to call create if instances are missing, similar to how other commands handle dependencies. Check the `base.py` for common patterns.
Tech stack
python
Domain
clideveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Basic Molecule knowledgePython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60