ankidroid/Anki-Android

CI should test 16kb and non-16kb page alignment in libraries, packaging, and emulator

Open

#16,917 opened on Aug 20, 2024

View on GitHub
 (13 comments) (1 reaction) (1 assignee)Kotlin (2,789 forks)batch import
Blocked by dependencyCIHelp WantedTests

Repository metrics

Stars
 (11,132 stars)
PR merge metrics
 (Avg merge 9d 4h) (123 merged PRs in 30d)

Description

with upcoming need to be "16kb alignment clean" the CI matrix for emulator tests should be updated to run against a 16kb emulator as well as a regular emulator. Suggest using this API/image-name tuple:

android-35;google_apis_ps16k

The page size should be verified in CI prior to execution, via the tests on linked google doc

Additionally, the .apk should be extracted and have .so file verification of page-alignment checked, and finally the zipalign should be checked - otherwise we won't know if we have actually done the work or not, and we won't track any random regressions

Originally posted by @mikehardy in https://github.com/ankidroid/Anki-Android-Backend/pull/402#discussion_r1723732098

Contributor guide

Research direction
Start by examining the repository's CI workflow files, likely in .github/workflows. The issue references PR #402 in Anki Android Backend, which contains context on 16kb page alignment. The task involves adding an emulator test using the image 'android 35;google apis ps16k' and implementing checks for .so alignment and zipalign verification. Review the linked Google doc for the exact verification commands.
Tech stack
kotlinandroid
Domain
ci cdtesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Android CIGitHub Actionspage alignment concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35