alibaba/spring-cloud-alibaba

FileNotFoundException throws when rules is provided by local resources in classpath and executed in command line

Open

#462 opened on Mar 20, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (8,513 forks)batch import
area/sentinelgood first issue

Repository metrics

Stars
 (29,106 stars)
PR merge metrics
 (Avg merge 8d 14h) (3 merged PRs in 30d)

Description

Component: Sentinel

Description: If the rules were configured in local file in classpath and executed the built jar in command line, FileNotFoundException throws, says,

class path resource [sentinel.json] cannot be resolved to absolute file path because it does not reside in the file system:jar:file:/D:/projects/a/b/c/blabal.jar!/BOOT-INF/classes!/sentinel.json

Investigation: class: FileDataSourceProperties method:preCheck

Contributor guide

Research direction
The issue is in FileDataSourceProperties.preCheck where a classpath resource is accessed using absolute path resolution, which fails inside a JAR. Investigate using Spring's ResourceLoader to obtain an InputStream instead of a File. Look at other Spring components handling classpath resources for patterns. The fix is likely in the preCheck method to use `Resource.getInputStream()` instead of `File`.
Tech stack
javaspring
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaSpring BootMaven/Gradle
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50