airbnb/rheostat

Disabled Rheostat component is displayed with cursor: pointer

Open

#212 opened on Feb 15, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (215 forks)batch import
help wanted

Repository metrics

Stars
 (1,688 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi, I have a <Rheostat> component with disabled={true}, and it's getting displayed with a pointer cursor, making it appear to the user that this slider isn't disabled.

2019-02-15-133416_991x469_scrot

2019-02-15-133425_1012x509_scrot

Basically these sliders shouldn't be focusable either when they're disabled.

Contributor guide

Research direction
Investigate the CSS styles for the disabled state of the Rheostat component and ensure cursor: not allowed and pointer events: none are applied. Also check if tabIndex is set to 1 when disabled.
Tech stack
javascriptreact
Domain
frontendaccessibility
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80