Xabaril/AspNetCore.Diagnostics.HealthChecks

Redis Sentinel support

Open

#611 opened on Aug 17, 2020

View on GitHub
 (6 comments) (4 reactions) (0 assignees)C# (737 forks)batch import
feature requesthelp wanted

Repository metrics

Stars
 (3,776 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi. I use RedisHealthCheck to connect to the Redis cluster in Sentinel mode so my connection string specifies Sentinel addresses, not Redis: tst-srv1.domain.com:26379,tst-srv2.domain.com:26379,tst-srv3.domain.com:26379 . I get this error:

RedisServerException: Error: ERR unknown command ECHO

Contributor guide

Research direction
Investigate the RedisHealthCheck implementation to understand how it connects and uses the ECHO command. Modify the health check to use the PING command or a Sentinel specific command instead of ECHO, or implement a separate connection logic for Sentinel mode.
Tech stack
csharp
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RedisRedis Sentinel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65