WordPress/gutenberg

NumberControl: Disable dragging on touch devices

Open

#38,865 opened on Feb 16, 2022

View on GitHub
 (2 comments) (3 reactions) (0 assignees)JavaScript (3,893 forks)batch import
Good First Issue[Package] Components[Status] In Progress[Type] Bug

Repository metrics

Stars
 (9,607 stars)
PR merge metrics
 (Avg merge 18d 1h) (406 merged PRs in 30d)

Description

The drag-to-change-value gesture will not work nicely on touch devices unless we disable browser scrolling with touch-action: none.

There is a separate question of whether we really want this dragging gesture on touch devices, because there is no cursor affordance like on desktop. It’s also pretty easy to accidentally flick and change the value, when you just want to tap/move the caret or something.

I’m inclined to disable the drag gesture on touch devices.

Tested on iPhone (Mobile mode in DevTools has different behavior)

Contributor guide

Research direction
Investigate how to disable the drag gesture on touch devices, possibly by adding a CSS property or checking for touch support in the component.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75