Semantic-Org/Semantic-UI-React

Dropdown scroll position going top when adding options

Open

#3,721 opened on Jul 26, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (4,065 forks)batch import
help wantedneeds engineering

Repository metrics

Stars
 (13,136 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hello,

I did search in the 30+ issues opened but did not see anything similar. Here is the bug I've encountered :

Bug Report

When modifying options of a Dropdown while you are scrolling inside of it, the scroll position going full top.

Expected Result

Scroll staying on actual position

Actual Result

Scroll reseting to top

Version

SUIR@0.87.3

Testcase

In this Testcase, I simulated addition of elements when clicking on a button. FYI, in my reality case, I am doing an infinite scroll, which is adding elements when needed.

https://codesandbox.io/s/semantic-ui-react-example-1xvv7?fontsize=14

Contributor guide

Research direction
The issue reports that the Dropdown component's scroll position resets to top when its options are modified while scrolling. The testcase in the issue shows adding options via a button. The likely cause is that the component re renders and resets the scroll position. Investigate the Dropdown component source code, typically in `src/modules/Dropdown/Dropdown.js`. Look for how the scroll position is managed, possibly via a ref or state. The fix may involve preserving the scroll position before re render and restoring it after. Check if there are any lifecycle methods or hooks that handle this. Since the issue is old and unassigned, no linked PRs or comments exist.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactSemantic UI React basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70