Semantic-Org/Semantic-UI-React

Popup: can be triggered on hover and click

Open

#3,327 opened on Dec 7, 2018

View on GitHub
 (11 comments) (0 reactions) (0 assignees)JavaScript (4,065 forks)batch import
bughelp wantedstale

Repository metrics

Stars
 (13,136 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

https://react.semantic-ui.com/modules/popup/#usage-multiple

The desired behaviour of a on={['hover', 'click']}popup is to stay open when clicked and the user hovers out of the trigger, right? So e.g. the user can copy sth. out of the popup.

Right now it closes on leave after you clicked. Which is uncommon UX IMHO.

Contributor guide

Research direction
Investigate the popup event handling logic for hover and click triggers. The bug likely occurs because the hover leave event is not being ignored when the popup was opened by click. Trace the event handlers in the Popup component to ensure that hover leave does not close the popup if it was triggered by a click.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60