Microsoft/react-native-windows

Add Functional Tests for Touchable Highlight

Open

#12,465 opened on Nov 29, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (544 forks)batch import
Area: FabricArea: TestsNew ArchitectureWorkstream: Test Coverageenhancementgood first issue

Repository metrics

Stars
 (6,114 stars)
PR merge metrics
 (Avg merge 3d 17h) (62 merged PRs in 30d)

Description

Test cases should be added to the E2E test app (Fabric) to validate the following functionality scenarios.

### Tasks
- [ ] TouchableHighlight should update style upon fast refresh.
- [ ] TouchableHighlight should update underlayColor upon fast refresh.
- [ ] TouchableHighlight should update activeOpacity upon fast refresh.
- [x] TouchableHighlight should fire action upon press.
- [x] TouchableHighlight should fire action upon onPressIn.
- [x] TouchableHighlight should fire action upon onPressOut.
- [ ] TouchableHighlight should fire action upon onLongPress.
- [ ] TouchableHighlight should register press in clicked within hitSlop range.
- [x] TouchableHighlight should not be interactable when disabled.

Contributor guide

Research direction
Locate the E2E test app (Fabric) in the repository, likely under packages/e2e test app or similar. Review existing tests for TouchableHighlight to understand the testing patterns. Implement tests for the remaining unchecked tasks: fast refresh, underlayColor, activeOpacity, and hitSlop. Follow the pattern of already completed tasks (like onPress, onPressIn, etc.). Run the tests locally to ensure they pass.
Tech stack
javascripttypescript
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React Native testing basicsE2E test setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70