Microsoft/monaco-editor

[Bug] Language C highlights "class" as token

Open

#4,039 opened on Jun 23, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,283 forks)batch import
bughelp wantedlanguages-basic

Repository metrics

Stars
 (14,836 stars)
PR merge metrics
 (Avg merge 17h 9m) (14 merged PRs in 30d)

Description

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Monaco Editor Playground Link

Monaco Editor Playground Link

Monaco Editor Playground Code

const value = `typedef struct {
	xchar class;
} foo;`;

// Hover on each property to see its docs!
const myEditor = monaco.editor.create(document.getElementById("container"), {
	value,
	language: "cpp",
});

Reproduction Steps

  1. Go to https://microsoft.github.io/monaco-editor/
  2. Select Language c
  3. Write
typedef struct {
    int class;
}

Actual (Problematic) Behavior

See that class is highlighted as keyword

Expected Behavior

class is no keyword in C, it should be highlighted like any other variable

Additional Context

No response

Contributor guide

Research direction
Start by examining the C language tokenizer definition in the Monaco Editor source code, typically located at `src/basic languages/c/c.ts` or similar. The issue is that 'class' is incorrectly recognized as a keyword in C. Review the keywords list and remove 'class' from the C specific set, while ensuring C++ still includes it. Check existing tests to verify the change.
Tech stack
typescriptjavascriptc
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Knowledge of Monaco's tokenizationC language basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60