IntersectMBO/plutus

Add golden tests for the validation benchmarks

Open

#6,828 opened on Feb 10, 2025

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Haskell (511 forks)batch import
BenchmarksGood first issueInternalTeststatus: triagedtech debt

Repository metrics

Stars
 (1,637 stars)
PR merge metrics
 (Avg merge 6d 1h) (15 merged PRs in 30d)

Description

Currently the validation benchmarks don't seem to have any golden tests ensuring that what scripts evaluate to doesn't change. Unlike e.g. nofib or bitwise benchmarks (and lists ones have some property tests). We should fix that, otherwise an apparent optimization might as well turn out to be a bug.

Same about marlowe?

Contributor guide

Research direction
Examine how golden tests are implemented in other benchmark directories (e.g., nofib or bitwise) and replicate that pattern for the validation benchmarks. Also consider whether marlowe benchmarks require similar tests.
Tech stack
None
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70