Gallopsled/pwntools

Use ssh with proxy_sock has some problem

Open

#1,988 opened on Oct 29, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (1,684 forks)batch import
buggood first issue

Repository metrics

Stars
 (11,127 stars)
PR merge metrics
 (Avg merge 1d 2h) (5 merged PRs in 30d)

Description

When I use ssh with proxy_sock and proxy_sock is unix domain socket, getsockname will return '', and sockname[0] will cause an Exception

https://github.com/Gallopsled/pwntools/blob/7e03bfd5a659afeaa165094b39e0ecec90c547c4/pwnlib/tubes/ssh.py#L459-L461

Contributor guide

Research direction
The issue is in pwnlib/tubes/ssh.py around line 459-461 where getsockname returns an empty string for Unix domain sockets, causing an exception. The fix should handle the case where sockname is empty, possibly by checking the socket type or providing a default value. No linked PRs or maintainer comments provide additional direction.
Tech stack
python
Domain
security
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
basic Pythonunderstanding of Unix sockets
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75