FuelLabs/sway

Treat warnings as erros in ci step that builds examples

Open

#4,274 opened on Mar 13, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (5,421 forks)batch import
cicode qualitygood first issue

Repository metrics

Stars
 (61,702 stars)
PR merge metrics
 (Avg merge 5d 4h) (19 merged PRs in 30d)

Description

I think we should do our best to ensure that examples are state-of the art and should produce no warnings. To enforce that we can use the flag added in #4177 in our CI step.

Contributor guide

Research direction
Review the flag added in PR #4177. Locate the CI configuration file (likely .github/workflows/*.yml) and the step that builds examples. Add the appropriate flag to treat warnings as errors. Ensure the change passes CI tests.
Tech stack
rustgithub actions
Domain
build systemci cd
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
basic CI knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80